fix(installer): Add NSSM download mirror #639
Merged
Merged
Conversation
ppawlowski
changed the title
hardillb
approved these changes
Jun 2, 2026
There was a problem hiding this comment.
Pull request overview
This PR mitigates frequent 503 errors when installing the FlowFuse Device Agent on Windows (issue #638) by adding a FlowFuse-hosted S3 mirror as the primary NSSM download source, retaining nssm.cc as a fallback, and adding SHA-256 verification of the downloaded archive.
Changes:
- Add a FlowFuse S3 mirror URL as the preferred NSSM download source, with
nssm.ccas fallback. - Replace the PowerShell
Invoke-WebRequest-based download with a Gonet/httpimplementation that retries each source up to 3 times with linear backoff. - Verify the downloaded archive against a pinned SHA-256 checksum and discard partial/corrupt files on failure.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Steve-Mcl
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request adds the FlowFuse-hosted NSSM download mirror. Additionally, it adds checksum validation for the downloaded archive before continuing, ensuring both archive consistency and security.
Related Issue(s)
Fixes #638
Checklist
flowforge.yml?FlowFuse/helmto update ConfigMap TemplateFlowFuse/CloudProjectto update values for Staging/ProductionLabels
area:migrationlabel